From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31905 invoked by alias); 4 Mar 2014 06:05:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31888 invoked by uid 89); 4 Mar 2014 06:05:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Mar 2014 06:05:24 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WKiTf-0001LG-25 from Yao_Qi@mentor.com ; Mon, 03 Mar 2014 22:05:19 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 3 Mar 2014 22:05:18 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 3 Mar 2014 22:05:18 -0800 Message-ID: <53156C94.40009@codesourcery.com> Date: Tue, 04 Mar 2014 06:05:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid. References: <1393360363-5603-1-git-send-email-palves@redhat.com> <1393360363-5603-4-git-send-email-palves@redhat.com> In-Reply-To: <1393360363-5603-4-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00060.txt.bz2 I don't have much comments on the patch, just some nits on tests: On 02/26/2014 04:32 AM, Pedro Alves wrote: > + gdb_test "set scheduler-locking off" Use "gdb_test_no_output"? > + gdb_test "info breakpoints" > + gdb_test "set debug infrun 1" I don't see the purpose of doing these two tests. They apply to step-over-lands-on-watchpoint.exp too. -- Yao (齐尧)