From: Yao Qi <yao@codesourcery.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN
Date: Tue, 04 Mar 2014 01:38:00 -0000 [thread overview]
Message-ID: <53152E0B.9090107@codesourcery.com> (raw)
In-Reply-To: <531529CB.2020400@mentor.com>
On 03/04/2014 09:18 AM, Hui Zhu wrote:
> I cannot understand about this OB is not right. I have 2 questions to you:
> 1. Before my patch, does target-delegates.c that generated by make-target-delegates is same with current target-delegates.c?
No, as I said, I forgot to re-generate target-delegates.c.
> 2. Does this new target-delegates.c that generated by make-target-delegates can be built success?
No, we should use TARGET_DEFAULT_NORETURN instead of
TARGET_DEFAULT_RETURN, which is a mistake when I resolved conflicts.
struct traceframe_info *(*to_traceframe_info) (struct target_ops *)
TARGET_DEFAULT_NORETURN (tcomplain ());
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-03-04 1:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 15:55 Hui Zhu
2014-03-04 0:52 ` Yao Qi
2014-03-04 1:18 ` Hui Zhu
2014-03-04 1:38 ` Yao Qi [this message]
2014-03-05 1:17 ` Yao Qi
2014-03-05 20:04 ` Tom Tromey
2014-03-06 2:21 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53152E0B.9090107@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox