From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23954 invoked by alias); 28 Feb 2014 18:51:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23942 invoked by uid 89); 28 Feb 2014 18:51:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2014 18:51:30 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1SIpSeq025138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Feb 2014 13:51:28 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1SIpRjr023638; Fri, 28 Feb 2014 13:51:27 -0500 Message-ID: <5310DAAE.3040207@redhat.com> Date: Fri, 28 Feb 2014 18:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC v2] fix regressions with target-async References: <1393609699-26407-1-git-send-email-tromey@redhat.com> <5310D2F9.2090507@redhat.com> <874n3jf5zz.fsf@fleche.redhat.com> In-Reply-To: <874n3jf5zz.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00883.txt.bz2 On 02/28/2014 06:26 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Looks like a nice solution to me. I'm happy to see the > Pedro> find_default_... default methods disappear. > > FAOD there is still find_default_supports_disable_randomization. > I think this is fixable, but it wasn't related to the bug at hand. > > Pedro> But this looks bogus to me -- it's only reachable if you already > Pedro> have the target pushed because you're debugging a threaded core, > Pedro> and then do "attach"... > > Now that there's a public AIX box I suppose I have no excuse. I'll give > it a try and see what happens. If it fails then I think we'll need some > explicit field on the target rather than trying to deduce properties of > the target based on whether it implements some methods. I'm sure that if something goes wrong with AIX, we can sort out aix-thread.c out. There's should really be no need to push the thread_stratum target early before there's a process. linux-thread-db.c gets by without that just fine, so just this. -- Pedro Alves