From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9794 invoked by alias); 28 Feb 2014 12:06:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9784 invoked by uid 89); 28 Feb 2014 12:06:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2014 12:06:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1SC6Put021572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Feb 2014 07:06:25 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1SC6NwL011702; Fri, 28 Feb 2014 07:06:23 -0500 Message-ID: <53107BBE.6040407@redhat.com> Date: Fri, 28 Feb 2014 12:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [patchv3 1/8] Move utility functions to common/ References: <20140227213242.GB21121@host2.jankratochvil.net> In-Reply-To: <20140227213242.GB21121@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00857.txt.bz2 Looks fine to me, with a few nits. On 02/27/2014 09:32 PM, Jan Kratochvil wrote: > (strtoulst): Move decl from utils.h. > (hex2bin, bin2hex): Move decls from remote.h. This one looks stale. > --- a/gdb/common/common-utils.h > +++ b/gdb/common/common-utils.h > @@ -25,6 +25,25 @@ > #include > #include > > +/* Static target-system-dependent parameters for GDB. */ > + > +/* * Number of bits in a char or unsigned char for the target machine. > + Just like CHAR_BIT in but describes the target machine. */ > +#if !defined (TARGET_CHAR_BIT) > +#define TARGET_CHAR_BIT 8 > +#endif > + > +/* * If we picked up a copy of CHAR_BIT from a configuration file > + (which may get it by including ) then use it to set Sounds like common-utils.h should include limits.h? defs.h does include it. > + the number of bits in a host char. If not, use the same size > + as the target. */ > + > +#if defined (CHAR_BIT) > +#define HOST_CHAR_BIT CHAR_BIT > +#else > +#define HOST_CHAR_BIT TARGET_CHAR_BIT > +#endif I think host-defs.h might be a better home for this. (With the target version placed in a new target-defs.h perhaps. I won't insist though.) -- Pedro Alves