From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32466 invoked by alias); 26 Feb 2014 11:19:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32451 invoked by uid 89); 26 Feb 2014 11:19:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Feb 2014 11:19:41 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1QBJaRG007096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Feb 2014 06:19:36 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1QBJTAZ013003; Wed, 26 Feb 2014 06:19:30 -0500 Message-ID: <530DCDC1.3070402@redhat.com> Date: Wed, 26 Feb 2014 11:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [commit] Adjust ia64_linux_xfer_partial following to_xfer_partial API change. References: <1393345450-20878-1-git-send-email-brobecker@adacore.com> <530CD37F.3050106@redhat.com> <20140226021446.GA4348@adacore.com> In-Reply-To: <20140226021446.GA4348@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00776.txt.bz2 BTW, I forgot to say, but -- thanks for writing the change and commit logs! :-) -- Pedro Alves On 02/26/2014 02:14 AM, Joel Brobecker wrote: > > 0001-Re-implement-ia64-linux-nat.c-ia64_linux_xfer_partia.patch > > > From d16461aeef555da47e358b0f81c75912e4ea07e2 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Tue, 25 Feb 2014 20:45:50 -0500 > Subject: [PATCH] Re-implement ia64-linux-nat.c::ia64_linux_xfer_partial > > [description of this patch and ChangeLog entry by Joel Brobecker] > The recent implementation was questionable, and if it worked, it was > only by chance because the requested length is large enough that only > one read was sufficient. Note that the implementation before that > also made that assumption, in the form of only handling > TARGET_OBJECT_UNWIND_TABLE xfer requests when offset was zero. > > gdb/ChangeLog: > > * ia64-linux-nat.c (ia64_linux_xfer_partial): Reimplement > handling of object == TARGET_OBJECT_UNWIND_TABLE. > --- > gdb/ChangeLog | 5 +++++ > gdb/ia64-linux-nat.c | 35 +++++++++++++++++++++++------------ > 2 files changed, 28 insertions(+), 12 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index e60ec1c..16f4619 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2014-02-25 Pedro Alves > + > + * ia64-linux-nat.c (ia64_linux_xfer_partial): Reimplement + handling of object == TARGET_OBJECT_UNWIND_TABLE.