From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4350 invoked by alias); 24 Feb 2014 18:21:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4334 invoked by uid 89); 24 Feb 2014 18:21:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2014 18:21:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OILfXm026948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 13:21:42 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1OIKgeO018048; Mon, 24 Feb 2014 13:20:54 -0500 Message-ID: <530B8D7A.3090705@redhat.com> Date: Mon, 24 Feb 2014 18:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method References: <1392841775-19126-1-git-send-email-palves@redhat.com> <1392841775-19126-4-git-send-email-palves@redhat.com> <20140220154826.GD4113@adacore.com> <20140220155611.GA17210@adacore.com> <53062F86.6020409@redhat.com> <20140224175346.GB4154@adacore.com> In-Reply-To: <20140224175346.GB4154@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00727.txt.bz2 On 02/24/2014 05:53 PM, Joel Brobecker wrote: >>>>> 2014-02-19 Pedro Alves >>>>> >>>>> * procfs.c (procfs_target): Don't install procfs_xfer_memory as >>>>> deprecated_xfer_memory hook. >>>>> (procfs_xfer_partial): Call procfs_xfer_memory instead >>>>> of the deprecated_xfer_memory target hook. >>>>> (procfs_xfer_memory): Adjust interface as a to_xfer_partial >>>>> helper. >>>> >>>> FYI: I tried to test it, but the sparc-solaris debugger appears to be >>>> badly broken at the moment, and I won't have much time left this week >>>> to investigate the failures, so I'll schedule that for next week. > > It turns out that your patch fixes the breakage as a side-effect. > Since it's bad breakage, I pushed the patch immediately, after having > updated the revision log: Eh, cool, thanks! -- Pedro Alves