From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 761 invoked by alias); 21 Feb 2014 06:12:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 749 invoked by uid 89); 21 Feb 2014 06:12:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f175.google.com Received: from mail-pd0-f175.google.com (HELO mail-pd0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 21 Feb 2014 06:12:02 +0000 Received: by mail-pd0-f175.google.com with SMTP id w10so2856686pde.34 for ; Thu, 20 Feb 2014 22:12:00 -0800 (PST) X-Received: by 10.68.43.2 with SMTP id s2mr7131951pbl.60.1392963120646; Thu, 20 Feb 2014 22:12:00 -0800 (PST) Received: from [192.168.1.102] ([115.199.123.92]) by mx.google.com with ESMTPSA id ix5sm17383469pbd.36.2014.02.20.22.11.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 22:11:59 -0800 (PST) Message-ID: <5306EE2A.2060103@gmail.com> Date: Fri, 21 Feb 2014 06:12:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior References: <530612A8.4000903@gmail.com> <5306A9BC.4080701@codesourcery.com> In-Reply-To: <5306A9BC.4080701@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00678.txt.bz2 On 2014-2-21 9:19, Yao Qi wrote: >> gdb/windows-nat.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c >> index a570a1a..b76d94d 100644 >> --- a/gdb/windows-nat.c >> +++ b/gdb/windows-nat.c >> @@ -2480,7 +2480,7 @@ windows_xfer_shared_libraries (struct target_ops *ops, >> >> obstack_free (&obstack, NULL); >> *xfered_len = (ULONGEST) len; >> - return TARGET_XFER_OK; >> + return len ? TARGET_XFER_OK : TARGET_XFER_EOF; >> } >> >> static enum target_xfer_status > You still need a changelog entry. > Hi, Yao, The change log could be below, fell free to adjust, thanks. Windows: Fix target_xfer_partial: Assertion `*xfered_len > 0' failed. The failure was introduced in commit 9b409511d07fe375284701af34909fb539029caf, 2014-02-11. gdb/windows-nat.c (windows_xfer_shared_libraries) : If len is 0, it should return TARGET_XFER_EOF. Yuanhui Zhang