From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13232 invoked by alias); 21 Feb 2014 01:22:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13210 invoked by uid 89); 21 Feb 2014 01:22:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2014 01:22:19 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WGeoi-0002kc-2f from Yao_Qi@mentor.com ; Thu, 20 Feb 2014 17:22:16 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Feb 2014 17:22:15 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Thu, 20 Feb 2014 17:22:14 -0800 Message-ID: <5306A9BC.4080701@codesourcery.com> Date: Fri, 21 Feb 2014 01:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: asmwarrior CC: Subject: Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior References: <530612A8.4000903@gmail.com> In-Reply-To: <530612A8.4000903@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00675.txt.bz2 On 02/20/2014 10:35 PM, asmwarrior wrote: > The original code return len(len could be 0), but the new code just return TARGET_XFER_OK. > If len is 0, it should return TARGET_XFER_EOF(it is 0 in enum target_xfer_status declaration. > Yes, good catch! > So, a patch below is confirmed to fix the assert issue, an obvious fix, right? > This fix is obvious to me. Please wait for one day, if maintainers have no comments, push it in. > gdb/windows-nat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index a570a1a..b76d94d 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -2480,7 +2480,7 @@ windows_xfer_shared_libraries (struct target_ops *ops, > > obstack_free (&obstack, NULL); > *xfered_len = (ULONGEST) len; > - return TARGET_XFER_OK; > + return len ? TARGET_XFER_OK : TARGET_XFER_EOF; > } > > static enum target_xfer_status You still need a changelog entry. -- Yao (齐尧)