From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 0AD363851C12 for ; Wed, 27 May 2020 15:10:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0AD363851C12 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C381426F161; Wed, 27 May 2020 11:10:02 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UDKSSHsO3MLy; Wed, 27 May 2020 11:10:02 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 8C69F26F1E5; Wed, 27 May 2020 11:10:02 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 8C69F26F1E5 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Z0P2eJfqDhcn; Wed, 27 May 2020 11:10:02 -0400 (EDT) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 6DE3F26F42E; Wed, 27 May 2020 11:10:02 -0400 (EDT) Subject: Re: [PATCH v2 41.5/42] Move line_header_hash to dwarf2_per_objfile To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20200512210913.5593-1-simon.marchi@efficios.com> <87wo4xpgbm.fsf@tromey.com> From: Simon Marchi Message-ID: <5304eb49-53dd-0389-1b83-1bc7260f395d@efficios.com> Date: Wed, 27 May 2020 11:10:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87wo4xpgbm.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 15:10:04 -0000 On 2020-05-27 11:07 a.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> The `line_header_hash` field of `struct dwarf2_per_bfd` contains some > Simon> `struct line_header` objects. A `struct line_header` objects contains > Simon> some `file_entry` objects. A `file_entry` object contains a pointer to > Simon> the `symtab` object created from it. The `line_header_hash` is > Simon> therefore ultimately objfile-dependent and can't be shared as-is between > Simon> objfiles. > > Simon> Move it from `dwarf2_per_bfd` to `dwarf2_per_objfile`. > > This patch looks good. > > I wonder how hard it would be to remove this symtab link and share these > across objfiles. However, I don't think this is worth delaying the > series for. Same. I went for the obvious fix here, but once it's merged we can spend as much time as we want to try to migrate stuff from dwarf2_per_objfile to dwarf2_per_bfd. Thanks for the reviews! Simon