From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 4A739385DC07 for ; Wed, 1 Apr 2020 19:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A739385DC07 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-ohmEEZbgNuelzF348Yqv-Q-1; Wed, 01 Apr 2020 15:15:54 -0400 X-MC-Unique: ohmEEZbgNuelzF348Yqv-Q-1 Received: by mail-ed1-f72.google.com with SMTP id cm25so770349edb.14 for ; Wed, 01 Apr 2020 12:15:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VN82XYEczmg9Ftdh+O5iRfojSbYICrprQ8yvqzOcb3w=; b=ZbYmiYCPlj25F19Z90h3/ah4ruE2N8hCXG5Wlulpt+O9J7BKRITWxn/5IHDhra0qSO y4d+94xWYN8A/TJa1HvtaD9bxeYKOVLgikwWFgkiz0ZtoG+8E5jMWJpJxaUBMU4g5V4e 9QOd13CIGicAp0WIPj1r5veZnMVpzgLFxViyziei8r5KPx9nLMIS1krJeHIcOU5OnOo9 Hk9OrbXzE4bnhknG2Ff4LuNMLUtyRHSors/SgUk6Fo7Lcdh46wfH3MJUM+EK74iyHnE9 PmVYwMn1rc3M2mOdgJdWOGzb6foEq/qXOSgry4BNCEP4r5cnK6d3J9W2yzNF5MBXq9OJ oPZQ== X-Gm-Message-State: ANhLgQ1wwIC3+PeeySWqZXhl7yNksnDI0gI4dx1RSZVbmmNKL+MOmzrt qcIEJ34+z1wleJE2EAkzWCeVPeIfrUF9jb26l++h288z3UhbxB4tqfGDYhDDIoTLxnq4iAiBRI/ 27BxHjsCTi7C9bUV3OtlwRw== X-Received: by 2002:a17:906:4e16:: with SMTP id z22mr22127037eju.363.1585768552353; Wed, 01 Apr 2020 12:15:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsbcZsfAgUEDxejLS0QdUSdWR4F+tB/ZykIlfXfnvTOhzDM40+s/WTOE8RsaRhEkEs9rHEJDw== X-Received: by 2002:a17:906:4e16:: with SMTP id z22mr22127015eju.363.1585768552090; Wed, 01 Apr 2020 12:15:52 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id b11sm608046edj.20.2020.04.01.12.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2020 12:15:51 -0700 (PDT) Subject: Re: [PATCH 10/31] gdbserver/linux-low: turn 'breakpoint_kind_from_{pc, current_state}' into methods To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <2f5f8156b5f3ceeff985dbd1af983e1212f9027e.1583529166.git.tankut.baris.aktemur@intel.com> From: Pedro Alves Message-ID: <52fef52c-7e11-179f-81fc-a373be1e3b0f@redhat.com> Date: Wed, 1 Apr 2020 20:15:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <2f5f8156b5f3ceeff985dbd1af983e1212f9027e.1583529166.git.tankut.baris.aktemur@intel.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 19:15:58 -0000 On 3/6/20 9:31 PM, Tankut Baris Aktemur wrote: > @@ -257,7 +259,7 @@ riscv_breakpoint_kind_from_pc (CORE_ADDR *pcptr) > } > buf; > > - if (target_read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0 > + if (read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0 Is this really correct? It seems like an unrelated change. target_read_memory masks off breakpoint instructions, while read_memory doesn't, I believe. Thanks, Pedro Alves