From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LU9pFM2GsWm5zyMAWB0awg (envelope-from ) for ; Wed, 11 Mar 2026 11:14:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6O8DKcJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5HlVyeQG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6O8DKcJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5HlVyeQG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3AA771E089; Wed, 11 Mar 2026 11:14:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DAA361E089 for ; Wed, 11 Mar 2026 11:14:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 577A64BB58CE for ; Wed, 11 Mar 2026 15:14:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 577A64BB58CE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6O8DKcJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5HlVyeQG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=S6O8DKcJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5HlVyeQG Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 4D7214BB58BB for ; Wed, 11 Mar 2026 15:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D7214BB58BB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D7214BB58BB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773242014; cv=none; b=a/lqDOnTHDm7LKEThHqeBNMFWSw5GyAj9tp1DAcT/yb/R+NbszZ+jGX1SrE2zRh6kREJV3nqp2pBk7qBI8sjJ9vudkb9aC3HUaUU4a880twgF/eu298+P4sVF4oEptpXcTHGosCz9+gic0dJMMtCPobbL+IVzCiTVVYPXbKCr0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773242014; c=relaxed/simple; bh=Zscm8Pc6J33ENhj0WEk9Jex8yAv7nF65JoNwRKf7vL0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=kIkvNZtKGy0Bxg5X+Agi8xSyFWYV6NmK+TA68nLCV92KAi6BOB09b4Cv4ucanReTOA9d/tbvAk/C9UwdYAUGt0E2SqaznZ0aM7OeNc4z2b802RBC8fIyk3OzRHqehnQNhCRhJrGyghHYK+Qe3O5SN/x4MnM/ZieQgIIZtTlYk6E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D7214BB58BB Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 547D34D344; Wed, 11 Mar 2026 15:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773242013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7ubtFoWJSdOz8VVJUW9F6mWjL0+W0392rhmgFB9x0Q=; b=S6O8DKcJpCRraB+8T0nGxPRMRZD0HoN6xCUqOi6WMnjvryGuqBPNnbADw7qE12WlFrMVdf m7uaBxmyNhTtkT2nmIu8LZ9O+H3/TEkqOIy8z2zyyDjZrFpbZuTfbDNWfsn/oh4khtauRs pbpvoezd+gVYDT8FxUaiWuQ4S1U6hCw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773242013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7ubtFoWJSdOz8VVJUW9F6mWjL0+W0392rhmgFB9x0Q=; b=5HlVyeQGk5wPEyqUZ4hR5zWgtXcXMnPeIPQYTLYbDOJKzXaV9VgN3ek0d287zurSOqFFpC GmXRyNPz1hW8XeBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S6O8DKcJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=5HlVyeQG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773242013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7ubtFoWJSdOz8VVJUW9F6mWjL0+W0392rhmgFB9x0Q=; b=S6O8DKcJpCRraB+8T0nGxPRMRZD0HoN6xCUqOi6WMnjvryGuqBPNnbADw7qE12WlFrMVdf m7uaBxmyNhTtkT2nmIu8LZ9O+H3/TEkqOIy8z2zyyDjZrFpbZuTfbDNWfsn/oh4khtauRs pbpvoezd+gVYDT8FxUaiWuQ4S1U6hCw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773242013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7ubtFoWJSdOz8VVJUW9F6mWjL0+W0392rhmgFB9x0Q=; b=5HlVyeQGk5wPEyqUZ4hR5zWgtXcXMnPeIPQYTLYbDOJKzXaV9VgN3ek0d287zurSOqFFpC GmXRyNPz1hW8XeBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3CDA33FAA0; Wed, 11 Mar 2026 15:13:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Eq5SDZ2GsWlOSQAAD6G6ig (envelope-from ); Wed, 11 Mar 2026 15:13:33 +0000 Message-ID: <52f8de7f-62c7-4a04-919d-aedee3314b7f@suse.de> Date: Wed, 11 Mar 2026 16:13:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] [gdb/symtab] Tweak fix-up of truncated inline function block ranges From: Tom de Vries To: Andrew Burgess , gdb-patches@sourceware.org References: <20260302114849.1797017-1-tdevries@suse.de> <20260302114849.1797017-4-tdevries@suse.de> <875x738ybx.fsf@redhat.com> <4f490289-ad52-4aa9-b559-b6647b2de051@suse.de> Content-Language: en-US In-Reply-To: <4f490289-ad52-4aa9-b559-b6647b2de051@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 547D34D344 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/11/26 2:24 PM, Tom de Vries wrote: > On 3/10/26 5:05 PM, Andrew Burgess wrote: >> Which is why I tried to write DWARF assembler tests to cover edge cases >> as I found them, and I think it would be great if we could get such a >> test to cover this fix too. > > Agreed. > >> I'm happy to help with, or even write, the >> test, once I can reproduce the failure. > > My first try: > ... > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp b/gdb/ > testsuite/gdb.dwarf2/dw2-ext > end-inline-block.exp > index 9e4798b53f3..82d3f7e0310 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp > @@ -115,7 +115,7 @@ proc build_dwarf_for_contiguous_block { asm_file } { >          DW_LNS_copy > >          DW_LNE_set_address main_3 > -        line $::foo_call_line > +        line [expr $::foo_call_line + 1] >          DW_LNS_negate_stmt >          DW_LNS_copy > ... > doesn't seem to work (in the sense of causing failure with the fix > applied), I'll investigate a bit further to understand why. OK, I think this: ... diff --git a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp b/gdb/testsuite/gdb.dwarf2/dw2-ext end-inline-block.exp index 9e4798b53f3..4a88250d927 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp @@ -120,10 +120,10 @@ proc build_dwarf_for_contiguous_block { asm_file } { DW_LNS_copy DW_LNE_set_address main_4 + DW_LNS_advance_line 1 DW_LNS_copy DW_LNE_set_address main_5 - DW_LNS_advance_line 1 DW_LNS_negate_stmt DW_LNS_copy ... is the patch that represents the behavior I was seeing. The testcase doesn't completely pass though, I get: ... (gdb) PASS: $exp: contiguous block: step to second line of foo step^M 28 /* foo:3 */^M (gdb) PASS: $exp: contiguous block: step to third line of foo step^M 37 /* main:4 */^M (gdb) FAIL: $exp: contiguous block: set back to main ... so the message saying we're back in main is missing. Thanks, - Tom