From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41621 invoked by alias); 20 May 2018 23:49:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41609 invoked by uid 89); 20 May 2018 23:49:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 May 2018 23:49:53 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B3B631E4F7; Sun, 20 May 2018 19:49:51 -0400 (EDT) Subject: Re: [RFA] Use std::unique_ptr in dwarf2_read_debug_names To: Tom Tromey , gdb-patches@sourceware.org References: <20180519152316.18973-1-tom@tromey.com> From: Simon Marchi Message-ID: <52e98157-98c4-5c73-8e17-338d14d00b55@simark.ca> Date: Sun, 20 May 2018 23:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180519152316.18973-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00449.txt.bz2 On 2018-05-19 11:23 AM, Tom Tromey wrote: > This changes dwarf2_read_debug_names to use std::unique_ptr from the > outset. This simplifies the code that installs the resulting map into > dwarf2_per_objfile. LGTM. We maybe could add DISABLE_COPY_AND_ASSIGN to mapped_index_base, to ensure we don't make copies of mapped_index/mapped_debug_names by mistake. Simon