From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kNWCAzdwiWCwJwAAWB0awg (envelope-from ) for ; Wed, 28 Apr 2021 10:24:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 0C8631F11C; Wed, 28 Apr 2021 10:24:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 69F1D1E01F for ; Wed, 28 Apr 2021 10:24:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7FE23944419; Wed, 28 Apr 2021 14:24:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E7FE23944419 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619619893; bh=sKPVBkwb++9gEL3MWkOB2ATBXglUUwWsCQMBLhxWkxY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=pjBHVSI9TI6T/tSzocFmozlInWNuRR2xyiv8za/0F+VuySK6UN2cG6BT01VCw4LJ+ l9UzZi4ROTmuVUG4dhIoZiRO1ydAwbWQ/YXmws1ALdllondzd72PXKKxmsF0v7wTXt p9eGFS7zFCQa2j/cUZ62z6pGc9t8M+dqULPfDsVs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7F0893857000 for ; Wed, 28 Apr 2021 14:24:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7F0893857000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13SEOidQ016869 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 10:24:49 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13SEOidQ016869 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 880561E01F; Wed, 28 Apr 2021 10:24:44 -0400 (EDT) Subject: Re: [PATCH 15/43] Make DWARF evaluator return a single struct value To: Zoran Zaric , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-16-Zoran.Zaric@amd.com> <320722e8-79e8-1890-bda8-bccf57ad52a3@amd.com> Message-ID: <52d9a93b-da57-e395-c8c8-6111d00e6c10@polymtl.ca> Date: Wed, 28 Apr 2021 10:24:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <320722e8-79e8-1890-bda8-bccf57ad52a3@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 28 Apr 2021 14:24:44 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > I've just copied this whole block from the loc.c. Everything is replaced with a new implementation in the later patch. > > Do you still feel that I need to clean it up here or it doesn't really matter considering the later patches? Up to you. Keep in mind that I give comments that make sense by looking at the individual patches, without much context of what's coming after. For a change of this size, it would be too difficult for me to make comments considering the patchset as a whole, it just wouldn't fit in my head. So if some code gets removed down the road and doing the change isn't really useful, it's ok to say that and ignore the comment. Simon