From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13492 invoked by alias); 13 Feb 2014 10:38:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13483 invoked by uid 89); 13 Feb 2014 10:38:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2014 10:38:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1DAcIH6020716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Feb 2014 05:38:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1DAbA08013510; Thu, 13 Feb 2014 05:38:17 -0500 Message-ID: <52FCA056.20303@redhat.com> Date: Thu, 13 Feb 2014 10:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC v2 2/9] move some rsp bits into rsp-low.h References: <1391714966-12125-1-git-send-email-tromey@redhat.com> <1391714966-12125-3-git-send-email-tromey@redhat.com> <52FC89A6.8010806@codesourcery.com> In-Reply-To: <52FC89A6.8010806@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00451.txt.bz2 On 02/13/2014 09:00 AM, Yao Qi wrote: > We also need to compile rsp-low.c for IPA, and link rsp-low-ipa.o > in IPA. I get the ipa build error below, > > gcc -shared -fPIC -Wl,--no-undefined -g -O2 -I. -I../../../../git/gdb/gdbserver -I../../../../git/gdb/gdbserver/../common -I../../../../git/gdb/gdbserver/../regformats -I../../../../git/gdb/gdbserver/.. -I../../../../git/gdb/gdbserver/../../include -I../../../../git/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Wempty-body -Werror -DGDBSERVER \ > -Wl,--dynamic-list=../../../../git/gdb/gdbserver/proc-service.list -o libinproctrace.so ax-ipa.o tracepoint-ipa.o format-ipa.o utils-ipa.o regcache-ipa.o remote-utils-ipa.o common-utils-ipa.o tdesc-ipa.o print-utils-ipa.o i386-linux-ipa.o linux-i386-ipa.o -ldl -pthread > tracepoint-ipa.o: In function `cstr_to_hexstr': > /home/yao/Source/gnu/gdb/build-git/x86/gdb/gdbserver/../../../../git/gdb/gdbserver/tracepoint.c:6933: undefined reference to `bin2hex' > tracepoint-ipa.o: In function `cmd_qtstmat': > /home/yao/Source/gnu/gdb/build-git/x86/gdb/gdbserver/../../../../git/gdb/gdbserver/tracepoint.c:7080: undefined reference to `unpack_varlen_hex' > tracepoint-ipa.o: In function `probe_marker_at': > /home/yao/Source/gnu/gdb/build-git/x86/gdb/gdbserver/../../../../git/gdb/gdbserver/tracepoint.c:7034: undefined reference to `unpack_varlen_hex' > tracepoint-ipa.o: In function `unprobe_marker_at': > /home/yao/Source/gnu/gdb/build-git/x86/gdb/gdbserver/../../../../git/gdb/gdbserver/tracepoint.c:7003: undefined reference to `unpack_varlen_hex' > As these functions are only included if HAVE_UST, it's not surprising Tom didn't see this. > The fix is to compile rsp-low and link it with ipa, as below. > The compile error is fixed. OK, thanks! -- Pedro Alves