From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31583 invoked by alias); 12 Feb 2014 01:22:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31573 invoked by uid 89); 12 Feb 2014 01:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2014 01:22:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WDOXM-00077a-RB from Yao_Qi@mentor.com ; Tue, 11 Feb 2014 17:22:52 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 11 Feb 2014 17:22:52 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Tue, 11 Feb 2014 17:21:51 -0800 Message-ID: <52FACC71.8090407@codesourcery.com> Date: Wed, 12 Feb 2014 01:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Sanimir Agovic CC: , Subject: Re: [PATCH 1/2] nios2-tdep: set default frame base References: <1392110775-21242-1-git-send-email-sanimir.agovic@intel.com> <1392110775-21242-2-git-send-email-sanimir.agovic@intel.com> In-Reply-To: <1392110775-21242-2-git-send-email-sanimir.agovic@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00372.txt.bz2 On 02/11/2014 05:26 PM, Sanimir Agovic wrote: > @@ -1595,6 +1595,7 @@ nios2_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > dwarf2_append_unwinders (gdbarch); > frame_unwind_append_unwinder (gdbarch, &nios2_stub_frame_unwind); > frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind); > + frame_base_set_default (gdbarch, &nios2_stub_frame_base); Sanimir, some lines below, we have: frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind); /* Single stepping. */ set_gdbarch_software_single_step (gdbarch, nios2_software_single_step); /* Hook in ABI-specific overrides, if they have been registered. */ gdbarch_init_osabi (info, gdbarch); if (tdep->jb_pc >= 0) set_gdbarch_get_longjmp_target (gdbarch, nios2_get_longjmp_target); frame_base_set_default (gdbarch, &nios2_frame_base); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ so looks we can remove nios2_stub_frame_base. -- Yao (齐尧)