From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17435 invoked by alias); 8 Feb 2014 03:00:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17426 invoked by uid 89); 8 Feb 2014 03:00:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Feb 2014 03:00:48 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WBy9r-0006TV-RC from Yao_Qi@mentor.com ; Fri, 07 Feb 2014 19:00:43 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 7 Feb 2014 19:00:43 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Fri, 7 Feb 2014 19:00:03 -0800 Message-ID: <52F59D5B.2040308@codesourcery.com> Date: Sat, 08 Feb 2014 03:00:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [RFC v2 07/38] Add target_ops argument to to_close References: <1391720136-2121-1-git-send-email-tromey@redhat.com> <1391720136-2121-8-git-send-email-tromey@redhat.com> In-Reply-To: <1391720136-2121-8-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00233.txt.bz2 On 02/07/2014 04:55 AM, Tom Tromey wrote: > static int > -ppc_linux_region_ok_for_hw_watchpoint (CORE_ADDR addr, int len) > +ppc_linux_region_ok_for_hw_watchpoint (struct target_ops *self, > + CORE_ADDR addr, int len) > { > /* Handle sub-8-byte quantities. */ > if (len <= 0) > @@ -1672,7 +1674,8 @@ ppc_linux_ranged_break_num_registers (struct target_ops *target) > success, 1 if hardware breakpoints are not supported or -1 for failure. */ ppc_linux_region_ok_for_hw_watchpoint calls ppc_linux_get_hwcap, which uses current_target, /* Fetch the AT_HWCAP entry from the aux vector. */ static unsigned long ppc_linux_get_hwcap (void) { CORE_ADDR field; if (target_auxv_search (¤t_target, AT_HWCAP, &field)) return (unsigned long) field; return 0; } Do we need to add argument 'ops' to ppc_linux_get_hwcap and stop using current_target in ppc_linux_get_hwcap? You may have done that in the following patches, and it is not surprise I miss it. Likewise, we need to add argument 'ops' to s390_get_hwcap too, and pass ops from its caller. -- Yao (齐尧)