From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32415 invoked by alias); 7 Feb 2014 16:47:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32406 invoked by uid 89); 7 Feb 2014 16:47:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2014 16:47:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s17GlOgW031138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Feb 2014 11:47:28 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s17G76LI030535; Fri, 7 Feb 2014 11:07:07 -0500 Message-ID: <52F504AA.2050108@redhat.com> Date: Fri, 07 Feb 2014 16:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC v2 00/38] clean up target delegation References: <1391720136-2121-1-git-send-email-tromey@redhat.com> In-Reply-To: <1391720136-2121-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00215.txt.bz2 On 02/06/2014 08:54 PM, Tom Tromey wrote: > This is revision 2 of the target delegation cleanup series. The > original series is here: > > https://sourceware.org/ml/gdb-patches/2014-01/msg00331.html > > This submission is, again, a squashed version of the series I actually > developed. I've redone the squashing using the same patch bundlings > as before. > > When the time comes, I plan to merge the atomized series rather than > this one; the squashing having been done to avoid an email flood and > to bundle the more mechanical patches in an attempt to make reviews > less strenuous. > > This series differs from the original in several ways, though I > believe none of the changes are truly major. > > I believe this version addresses all the reviews. > > It required minor changes here and there when I rebased. I didn't > generally make a record of these fixes, but they were all simply > adaptations either to patches that went in earlier, or to other > patches touching target methods. > > A couple of patches from the old series have already been pushed. > > Patches 33-38 in this series are new to this revision. They all arose > from reviews of the first series. I believe they were all reviewed > already by Pedro. There were a couple that we only discussed on internal IRC, I believe. FAOD, I've replied to those. > Built and regtested on x86-64 Fedora 18. Due to the relatively minor > nature of the changes from revision 1, I did not redo the more > comprehensive testing I did of that revision. I cross checked my previous comments against the new series, only noticed only a couple small details. I didn't look again at patches where in v1 they already looked fine to me. So to me, with patches #2 and #4 addressed, this is good to me. Am I looking forward to it. -- Pedro Alves