[PATCH 6/6] Update comments to to_xfer_partial implementations.

Yao Qi
2014-01-31T03:38:58Z

Some comments to to_xfer_partial implementations are out of date.
This patch updates them using the "Implement the to_xfer_partial
target_ops method" pattern.

gdb:

2014-01-30 Yao Qi <yao@codesourcery.com>

* aix-thread.c (aix_thread_xfer_partial): Update comments.
* auxv.c (procfs_xfer_auxv, memory_xfer_auxv): Likewise.
* bsd-uthread.c (bsd_uthread_xfer_partial): Likewise.
* gnu-nat.c (gnu_xfer_memory): Likewise.
* inf-ptrace.c (inf_ptrace_xfer_partial): Likewise.
* rs6000-nat.c (rs6000_xfer_partial): Likewise.
* sparc-nat.c (sparc_xfer_wcookie): Likewise.
* spu-linux-nat.c (spu_proc_xfer_spu): Likewise.
---
gdb/aix-thread.c | 4 +---
gdb/auxv.c | 9 +++++----
gdb/bsd-uthread.c | 5 +++--
gdb/gnu-nat.c | 3 ++-
gdb/inf-ptrace.c | 4 +---
gdb/rs6000-nat.c | 5 +----
gdb/sparc-nat.c | 3 ++-
gdb/spu-linux-nat.c | 4 +++-
8 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index 4feb0cb..bd2a3a1 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -1678,9 +1678,7 @@ aix_thread_store_registers (struct target_ops *ops,
}
}

-/* Attempt a transfer all LEN bytes starting at OFFSET between the
- inferior's OBJECT:ANNEX space and GDB's READBUF/WRITEBUF buffer.
- Return the number of bytes actually transferred. */
+/* Implement the to_xfer_partial target_ops method. */

static enum target_xfer_status
aix_thread_xfer_partial (struct target_ops *ops, enum target_object object,
diff --git a/gdb/auxv.c b/gdb/auxv.c
index 50009d8..4886992 100644
--- a/gdb/auxv.c
+++ b/gdb/auxv.c
@@ -35,8 +35,9 @@
#include <fcntl.h>

-/* This function handles access via /proc/PID/auxv, which is a common
- method for native targets. */
+/* Implement the to_xfer_partial target_ops method. This function
+ handles access via /proc/PID/auxv, which is a common method for
+ native targets. */

static enum target_xfer_status
procfs_xfer_auxv (gdb_byte *readbuf,
@@ -215,8 +216,8 @@ ld_so_xfer_auxv (gdb_byte *readbuf,
return TARGET_XFER_OK;
}

-/* This function is called like a to_xfer_partial hook, but must be
- called with TARGET_OBJECT_AUXV. It handles access to AUXV. */
+/* Implement the to_xfer_partial target_ops method for
+ TARGET_OBJECT_AUXV. It handles access to AUXV. */

enum target_xfer_status
memory_xfer_auxv (struct target_ops *ops,
diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c
index 446bbd2..bf6c390 100644
--- a/gdb/bsd-uthread.c
+++ b/gdb/bsd-uthread.c
@@ -331,8 +331,9 @@ bsd_uthread_store_registers (struct target_ops *ops,
}
}

-/* FIXME: This function is only there because otherwise GDB tries to
- invoke deprecate_xfer_memory. */
+/* Implement the to_xfer_partial target_ops method. FIXME: This
+ function is only there because otherwise GDB tries to invoke
+ deprecate_xfer_memory. */

static enum target_xfer_status
bsd_uthread_xfer_partial (struct target_ops *ops, enum target_object object,
diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index b5a8da0..efafc35 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -2473,7 +2473,8 @@ out:

\f

-/* Helper for gnu_xfer_partial that handles memory transfers. */
+/* Implement the to_xfer_partial target_ops method for
+ TARGET_OBJECT_MEMORY. */

static enum target_xfer_status
gnu_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index 0876366..85e7e65 100644
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -455,9 +455,7 @@ inf_ptrace_wait (struct target_ops *ops,
return pid_to_ptid (pid);
}

-/* Attempt a transfer all LEN bytes starting at OFFSET between the
- inferior's OBJECT:ANNEX space and GDB's READBUF/WRITEBUF buffer.
- Return the number of bytes actually transferred. */
+/* Implement the to_xfer_partial target_ops method. */

static enum target_xfer_status
inf_ptrace_xfer_partial (struct target_ops *ops, enum target_object object,
diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c
index dfd59d9..606da52 100644
--- a/gdb/rs6000-nat.c
+++ b/gdb/rs6000-nat.c
@@ -374,10 +374,7 @@ rs6000_store_inferior_registers (struct target_ops *ops,
}
}

-
-/* Attempt a transfer all LEN bytes starting at OFFSET between the
- inferior's OBJECT:ANNEX space and GDB's READBUF/WRITEBUF buffer.
- Return the number of bytes actually transferred. */
+/* Implement the to_xfer_partial target_ops method. */

static enum target_xfer_status
rs6000_xfer_partial (struct target_ops *ops, enum target_object object,
diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c
index f29b4e9..a03c093 100644
--- a/gdb/sparc-nat.c
+++ b/gdb/sparc-nat.c
@@ -256,7 +256,8 @@ sparc_store_inferior_registers (struct target_ops *ops,
}

\f
-/* Fetch StackGhost Per-Process XOR cookie. */
+/* Implement the to_xfer_partial target_ops method for
+ TARGET_OBJECT_WCOOKIE. Fetch StackGhost Per-Process XOR cookie. */

static enum target_xfer_status
sparc_xfer_wcookie (struct target_ops *ops, enum target_object object,
diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c
index 105529d..0127fd5 100644
--- a/gdb/spu-linux-nat.c
+++ b/gdb/spu-linux-nat.c
@@ -226,8 +226,10 @@ parse_spufs_run (int *fd, ULONGEST *addr)
}

-/* Copy LEN bytes at OFFSET in spufs file ANNEX into/from READBUF or WRITEBUF,
+/* Implement the to_xfer_partial target_ops method for TARGET_OBJECT_SPU.
+ Copy LEN bytes at OFFSET in spufs file ANNEX into/from READBUF or WRITEBUF,
using the /proc file system. */
+
static enum target_xfer_status
spu_proc_xfer_spu (const char *annex, gdb_byte *readbuf,
const gdb_byte *writebuf,
--
1.7.7.6