From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22078 invoked by alias); 6 Feb 2014 14:44:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22020 invoked by uid 89); 6 Feb 2014 14:44:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2014 14:44:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s16EiDu9001479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Feb 2014 09:44:13 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s16EiBlD005469; Thu, 6 Feb 2014 09:44:12 -0500 Message-ID: <52F39FBB.9080902@redhat.com> Date: Thu, 06 Feb 2014 14:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Return early in target_xfer_partial when LEN is zero. References: <1391139325-2758-1-git-send-email-yao@codesourcery.com> <1391139325-2758-5-git-send-email-yao@codesourcery.com> In-Reply-To: <1391139325-2758-5-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00094.txt.bz2 On 01/31/2014 03:35 AM, Yao Qi wrote: > Nowadays, argument LEN of to_xfer_partial can be zero in some cases, > and each implementation may do nothing and return zero, indicating > transfer is done. That is fine. However, when we change > to_xfer_partial to return target_xfer_status, we have to check every > return value of most of to_xfer_partial implementations, return > TARGET_XFER_DONE if return value is zero. > > This patch simplifies this by checking LEN in target_xfer_partial, and > return 0 if LEN is zero. Regression tested on x86_84-linux. Is it > OK? OK. Thanks. -- Pedro Alves