From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18925 invoked by alias); 6 Feb 2014 14:43:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18896 invoked by uid 89); 6 Feb 2014 14:43:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2014 14:43:28 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s16EhMKw020841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Feb 2014 09:43:23 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s16EhLd5015061; Thu, 6 Feb 2014 09:43:22 -0500 Message-ID: <52F39F88.5020307@redhat.com> Date: Thu, 06 Feb 2014 14:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] core_xfer_shared_libraries and core_xfer_shared_libraries_aix returns ULONGEST References: <1391139325-2758-1-git-send-email-yao@codesourcery.com> <1391139325-2758-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1391139325-2758-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00092.txt.bz2 On 01/31/2014 03:35 AM, Yao Qi wrote: > This patch specifies the return value of core_xfer_shared_libraries_aix > and core_xfer_shared_libraries, and change return value to ULONGEST. > > The following patch can check its return value in core_xfer_partial > and return appropriate target_xfer_status in core_xfer_partial. I got a little confused reading this. I suggest: This patch documents the return value of core_xfer_shared_libraries_aix and core_xfer_shared_libraries gdbarch hooks, and changes their return type to ULONGEST from LONGEST. In a following patch, core_xfer_partial is changed to check their return values and return an appropriate target_xfer_status. > # Read offset OFFSET of TARGET_OBJECT_LIBRARIES formatted shared libraries list from > -# core file into buffer READBUF with length LEN. > -M:LONGEST:core_xfer_shared_libraries:gdb_byte *readbuf, ULONGEST offset, ULONGEST len:readbuf, offset, len > +# core file into buffer READBUF with length LEN. Return the number of bytes read ( > +# zero indicates failure). Nit, please put the opening '(' on the next line. Looks a little odd to me that way. Like: > +# core file into buffer READBUF with length LEN. Return the number of bytes read > +# (zero indicates failure). Otherwise OK. Thanks, -- Pedro Alves