From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3225 invoked by alias); 6 Feb 2014 12:41:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3213 invoked by uid 89); 6 Feb 2014 12:41:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2014 12:41:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s16CfoIq012026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Feb 2014 07:41:50 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s16CfnKh015773; Thu, 6 Feb 2014 07:41:50 -0500 Message-ID: <52F3830D.3070201@redhat.com> Date: Thu, 06 Feb 2014 12:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Tweak in memory_error References: <1391139325-2758-1-git-send-email-yao@codesourcery.com> <1391139325-2758-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1391139325-2758-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00085.txt.bz2 On 01/31/2014 03:35 AM, Yao Qi wrote: > This patch adds a local variable exception of type 'enum errors' and > pass it to throw_error. Ah, took me a second to realize _why_. OK, but could you add this to the commit log please ? : 'err' is of type 'enum target_xfer_error', and we're abusing it to store an 'enum errors'. Thanks! -- Pedro Alves > > gdb: > > 2014-01-30 Yao Qi > > * corefile.c (memory_error): Get 'exception' from ERR and pass > 'exception' to throw_error. > --- > gdb/corefile.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/corefile.c b/gdb/corefile.c > index 1ed8395..93f5e04 100644 > --- a/gdb/corefile.c > +++ b/gdb/corefile.c > @@ -221,6 +221,7 @@ void > memory_error (enum target_xfer_error err, CORE_ADDR memaddr) > { > char *str; > + enum errors exception = GDB_NO_ERROR; > > /* Build error string. */ > str = memory_error_message (err, target_gdbarch (), memaddr); > @@ -230,15 +231,15 @@ memory_error (enum target_xfer_error err, CORE_ADDR memaddr) > switch (err) > { > case TARGET_XFER_E_IO: > - err = MEMORY_ERROR; > + exception = MEMORY_ERROR; > break; > case TARGET_XFER_E_UNAVAILABLE: > - err = NOT_AVAILABLE_ERROR; > + exception = NOT_AVAILABLE_ERROR; > break; > } > > /* Throw it. */ > - throw_error (err, ("%s"), str); > + throw_error (exception, ("%s"), str); > } > > /* Same as target_read_memory, but report an error if can't read. */ >