From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23711 invoked by alias); 6 Feb 2014 12:27:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23650 invoked by uid 89); 6 Feb 2014 12:27:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2014 12:27:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s16CRmKg013394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Feb 2014 07:27:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s16CRlhF032326; Thu, 6 Feb 2014 07:27:47 -0500 Message-ID: <52F37FC2.5040001@redhat.com> Date: Thu, 06 Feb 2014 12:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/3] remove all_lwps from gdbserver: use list api References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00081.txt.bz2 On 01/29/2014 06:11 PM, Doug Evans wrote: > +/* Return a pointer to the first inferior in the list, or NULL if there > + isn't one. > + This is for cases where the caller needs a thread, but doesn't care > + which one. */ > + > +struct inferior_list_entry * > +get_first_inferior (void) > +{ > + if (all_threads.head != NULL) > + return all_threads.head; I think this one, being an "inferior" function, should take a list as argument. > + return NULL; > +} > + > +/* Helper for gdb_agent_about_to_close. > + Return non-zero if thread ENTRY is in the same process in DATA. */ > + > +static int > +same_process_p (struct inferior_list_entry *inf, void *data) Mismatch between comment and parameter (ENTRY vs inf). Otherwise looks good to me. (Note: I noticed that patch 3 had a hunk that should be here: if (!non_stop) { - current_inferior = (struct thread_info *) all_threads.head; + current_inferior = get_first_thread (); ) -- Pedro Alves