Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 4/9] don't let hexify call strlen
Date: Wed, 05 Feb 2014 20:37:00 -0000	[thread overview]
Message-ID: <52F2A0FA.3090106@redhat.com> (raw)
In-Reply-To: <1390245501-1186-5-git-send-email-tromey@redhat.com>

On 01/20/2014 07:18 PM, Tom Tromey wrote:
> hexify had the same issue as bin2hex; and the fix is the same.
> 
> 2014-01-20  Tom Tromey  <tromey@redhat.com>
> 
> 	* common/rsp-low.c (hexify): Never take strlen of argument.
> 
> 2014-01-20  Tom Tromey  <tromey@redhat.com>
> 
> 	* remote-utils.c (monitor_output): Pass explicit length to
> 	hexify.

OK.

Thanks,
-- 
Pedro Alves


  reply	other threads:[~2014-02-05 20:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 19:18 [RFC 0/9] move more code into common/ Tom Tromey
2014-01-20 19:18 ` [RFC 3/9] don't let bin2hex call strlen Tom Tromey
2014-02-05 20:36   ` Pedro Alves
2014-01-20 19:18 ` [RFC 1/9] share "cell" code Tom Tromey
2014-02-05 20:05   ` Pedro Alves
2014-02-05 20:13     ` Tom Tromey
2014-02-06  2:28       ` Yao Qi
2014-02-06 18:51         ` Tom Tromey
2014-01-20 19:18 ` [RFC 6/9] replace convert_int_to_ascii with bin2hex Tom Tromey
2014-02-05 20:39   ` Pedro Alves
2014-01-20 19:18 ` [RFC 2/9] move some rsp bits into rsp-low.h Tom Tromey
2014-01-21  3:24   ` Yao Qi
2014-02-05 20:33   ` Pedro Alves
2014-02-06 18:56     ` Tom Tromey
2014-02-06 19:08       ` Pedro Alves
2014-01-20 19:23 ` [RFC 5/9] replace hexify with bin2hex Tom Tromey
2014-02-05 20:38   ` Pedro Alves
2014-01-20 19:23 ` [RFC 9/9] update rsp-low comments Tom Tromey
2014-02-05 22:22   ` Pedro Alves
2014-01-20 19:23 ` [RFC 4/9] don't let hexify call strlen Tom Tromey
2014-02-05 20:37   ` Pedro Alves [this message]
2014-01-20 19:23 ` [RFC 8/9] replace convert_ascii_to_int with hex2bin Tom Tromey
2014-02-05 22:18   ` Pedro Alves
2014-01-20 19:38 ` [RFC 7/9] replace unhexify " Tom Tromey
2014-02-05 22:14   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F2A0FA.3090106@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox