From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2566 invoked by alias); 5 Feb 2014 20:05:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2548 invoked by uid 89); 5 Feb 2014 20:05:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Feb 2014 20:05:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s15K5lGQ021269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Feb 2014 15:05:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s15K5j5O020147; Wed, 5 Feb 2014 15:05:46 -0500 Message-ID: <52F29999.5070009@redhat.com> Date: Wed, 05 Feb 2014 20:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 1/9] share "cell" code References: <1390245501-1186-1-git-send-email-tromey@redhat.com> <1390245501-1186-2-git-send-email-tromey@redhat.com> In-Reply-To: <1390245501-1186-2-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00048.txt.bz2 On 01/20/2014 07:18 PM, Tom Tromey wrote: > The "cell"-based printing code, like phex, was duplicated in both gdb > and gdbserver. This patch merges the two implementations into a new > file in common/. > Looks good to me, though I have to admit the choice of "cell" for filenames feels a little "called for how its implemented, rather than for what it actually serves" to me. IOW, this is printing stuff, and I find it just surprising to not find it in a file called something that at least starts with 'p', if not 'print.h/c' even. Failing that, perhaps pcell.h/c ? Anyway, forward it is. OK. > 2014-01-20 Tom Tromey > > * utils.c (NUMCELLS, CELLSIZE, get_cell, decimal2str, pulongest) > (plongest, thirty_two, phex, phex_nz, octal2str, hex_string) > (hex_string_custom, int_string, core_addr_to_string) > (core_addr_to_string_nz, host_address_to_string): Move to > common/cells.c. > * common/cells.h: New file. > * common/cells.c: New file > * Makefile.in (SFILES): Add common/cells.c. > (HFILES_NO_SRCDIR): Add common/cells.h. > (COMMON_OBS): Add cells.o. > (cells.o): New target. > > 2014-01-20 Tom Tromey > > * utils.c (NUMCELLS, CELLSIZE, get_cell, decimal2str, pulongest) > (plongest, thirty_two, phex_nz): Remove. > * Makefile.in (SFILES): Add common/cells.c. > (OBS): Add cells.o. > (cell-ipas.o): New target. > (cells.o): New target. > (IPA_OBJS): Add cells-ipa.o. -- Pedro Alves