Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case

Pedro Alves
2014-01-17T18:20:23Z

BTW,

(adding Omair)

On 01/17/2014 05:58 PM, Andreas Arnez wrote:
> +/* Notes: (1) The '*_start' label below is needed because 'name' may
> + point to a function descriptor instead of to the actual code. (2)
> + The '.balign' should specify the highest possible function
> + alignment across all supported architectures, such that the label
> + never points into the alignment gap. */
> +
> #define FUNC(name) \
> - void \
> + asm (".balign 8"); \
> + asm (#name "_start: .globl " #name "_start\n"); \
> + static void \
> name (void) \

Not sure you were following the
"testsuite/gdb.dwarf2: Fix for dw2-ifort-parameter failure on ARM"
thread. Seems to me this exact same thing should be done to
dw2-ifort-parameter.c. I assume that test is currently failing
on ppc64 for the exact same reason, and that if it's not failing
on S390 with current gcc, it'll be by lucky alignment. I believe
this approach should fix Thumb there as well. Can you guys
coordinate on handling that test? Thanks.

--
Pedro Alves