From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7403 invoked by alias); 17 Jan 2014 12:46:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7394 invoked by uid 89); 17 Jan 2014 12:46:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 12:46:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HCkenO028993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jan 2014 07:46:41 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0HCkdMR020470; Fri, 17 Jan 2014 07:46:40 -0500 Message-ID: <52D9262F.7080102@redhat.com> Date: Fri, 17 Jan 2014 12:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Doug Evans CC: Yao Qi , gdb-patches Subject: Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability References: <52B1842F.5020401@redhat.com> <21205.55987.69477.892571@ruffy.mtv.corp.google.com> <52D826DF.4000505@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00673.txt.bz2 On 01/16/2014 07:01 PM, Doug Evans wrote: >> > >> > utils.c is compiled to both gdbserver and ipa. IMO, >> > ipa code should be thread-safe, because it can be used by a >> > multi-threaded program. > That would argue for removing the indentation support, at least for now. > Fine by me. > > OTOH, it seemed like ipa code has its own debug printf'ing so it can > prepend PROG, so I'm not sure this is necessary. It's more a per-module thing, than a per-program thing. E.g., ax.c. Certainly PROG handling could (or perhaps should even?) be moved to debug_printf. (And ax_debug made a client of debug_printf). > OTOOH, it'd be less preferable to assume(!) ipa code would never call > debug_printf. Yeah. > Thoughts? -- Pedro Alves