From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6703 invoked by alias); 17 Jan 2014 12:46:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6694 invoked by uid 89); 17 Jan 2014 12:46:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 12:46:28 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HCkODI021581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jan 2014 07:46:24 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0HCkNux023869; Fri, 17 Jan 2014 07:46:23 -0500 Message-ID: <52D9261E.8080201@redhat.com> Date: Fri, 17 Jan 2014 12:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Doug Evans CC: Yao Qi , gdb-patches Subject: Re: [PATCH 1/3] gdbserver debug_printf+timestamps: FUNCTION_NAME References: <52B1842F.5020401@redhat.com> <21205.55987.69477.892571@ruffy.mtv.corp.google.com> <52D81569.3080006@redhat.com> <52D82AD5.7000306@redhat.com> <21208.27400.695984.88504@ruffy.mtv.corp.google.com> <21208.27605.74231.313332@ruffy.mtv.corp.google.com> In-Reply-To: <21208.27605.74231.313332@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00672.txt.bz2 On 01/16/2014 11:31 PM, Doug Evans wrote: > Doug Evans writes: > > v2 is now split into three parts: > > > > 1/3 - move ASSERT_FUNCTION to FUNCTION_NAME in common-utils.h > > 2/3 - create new function delim_string_to_char_ptr_vec_append in gdb_vecs.c > > 3/3 - the actual debug_printf patch > > > > I went with --debug[=timestamp] as the option naming. > > I didn't do a darwin build but the change is mechanical. > > 2014-01-16 Doug Evans > > * common/common-utils.h (FUNCTION_NAME): Renamed from ASSERT_FUNCTION, > and moved here ... > * common/gdb_assert.h (ASSERT_FUNCTION): ... from here. > #include "common-utils.h". > (gdb_assert, gdb_assert_fail, gdb_assert_not_reached): Update. > * common/vec.h (VEC_ASSERT_PASS): Update. > * darwin-nat.h: Replace #include of gdb_assert.h with common-utils.h. > (MACH_CHECK_ERROR): Update. Looks good to me. Thanks, -- Pedro Alves