From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28391 invoked by alias); 16 Jan 2014 19:58:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28378 invoked by uid 89); 16 Jan 2014 19:58:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 19:58:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GJvxD6026699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 14:58:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0GJvwLq003862; Thu, 16 Jan 2014 14:57:58 -0500 Message-ID: <52D839C5.2070606@redhat.com> Date: Thu, 16 Jan 2014 19:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Simon Marchi , GDB Patches Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags References: <52D8293B.6060701@ericsson.com> <52D82EDF.5010402@redhat.com> <52D8327D.7010403@redhat.com> <52D833E8.8090308@ericsson.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00651.txt.bz2 On 01/16/2014 07:44 PM, Sergio Durigan Junior wrote: > On Thursday, January 16 2014, Simon Marchi wrote: > >> I'm ok with that. Actually, I looked around to try to keep the same style, but I stumbled upon a "bad" example :P > > $ git grep "zero otherwise" | wc -l > 85 > $ git grep "false otherwise" | wc -l > 30 > > Not very hard to choose a "bad" example... Alright, you win. :-) Wishful thinking I guess. I do think true/false is better when we mean a boolean. We even had talks about using gnulib's bool before. Kind of moot/unnecessary if we do get to move to C++ though. -- Pedro Alves