From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6798 invoked by alias); 16 Jan 2014 19:11:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6788 invoked by uid 89); 16 Jan 2014 19:11:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 19:11:32 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GJBSWV026738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 14:11:29 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0GJBR3X011777; Thu, 16 Jan 2014 14:11:28 -0500 Message-ID: <52D82EDF.5010402@redhat.com> Date: Thu, 16 Jan 2014 19:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Simon Marchi CC: GDB Patches Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags References: <52D8293B.6060701@ericsson.com> In-Reply-To: <52D8293B.6060701@ericsson.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00644.txt.bz2 On 01/16/2014 06:47 PM, Simon Marchi wrote: > +/* Return the appropriate type_flags for the supplied address class. > + This function should return 1 if the address class was recognized and > + type_flags was set, zero otherwise. Say true/false instead of 1/zero. > + No assumption should be made about the initial value of *type_flags_ptr, > + which means that if it returns 1, the function should write it, even if > + no flags are set. */ This makes me a little confused. This is a mapping/conversion function: class name -> type flags I'd expect the function to recognize the name, and return a valid flag (thus return true), or not recognize the name, and return false. What would "even if no flags are set" mean? What's the use case for that? Recognizing a class name, but having that map to no flags? As in, ignoring the class name? Is that useful? -- Pedro Alves