From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1092 invoked by alias); 16 Jan 2014 14:17:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1077 invoked by uid 89); 16 Jan 2014 14:17:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_WEB,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ea0-f174.google.com Received: from mail-ea0-f174.google.com (HELO mail-ea0-f174.google.com) (209.85.215.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Jan 2014 14:17:02 +0000 Received: by mail-ea0-f174.google.com with SMTP id b10so1155778eae.5 for ; Thu, 16 Jan 2014 06:16:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QaYrv7puzMTEa6SsKs7O6MjVP1Gv9NjQtav9F5pxnDk=; b=CoSOFPmzM3v/da8kWoAfHGtseGDV1NxyKdT8+VvmZbq9F8tavACGJMkVwUC7j6aHIL gk5utCIw1RpfOE3mwOtVZTUAibk7D8xfwve3vwGkQN/grQjXdYdo+a6yq2HsMrXiIrHb 9uBzAdH83C1FMzv+44lvvXVJF0qfgrq/auUj673caWxp1Md0kINuMARYSqE0gUiZRMQ2 Joenv7oCRpuLX1F7TxcJaYDo+OYhEBlUDxjpfCVT/cgHQBBZaGsUDITrRg/k7mPbl9+I Q/GGzVtf3B68JC4lV9uMQ3hF/IClZMXMNEmpocoZYYDBqLp/e/UCIjxxEVzGOQ85vzsP ogAQ== X-Gm-Message-State: ALoCoQlXWj1jNI51W6slDGrUJ9ONpuaLd7ElfIRc+uOQtJLI9GshyoYS7mTg0j73K82NvtO2Yz/W X-Received: by 10.14.6.5 with SMTP id 5mr12380154eem.51.1389881819366; Thu, 16 Jan 2014 06:16:59 -0800 (PST) Received: from [192.168.1.102] ([182.185.178.235]) by mx.google.com with ESMTPSA id 46sm2146852ees.4.2014.01.16.06.16.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 16 Jan 2014 06:16:58 -0800 (PST) Message-ID: <52D7E9D7.80309@linaro.org> Date: Thu, 16 Jan 2014 14:17:00 -0000 From: Omair Javaid User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Pedro Alves CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite/gdb.dwarf2: Fix for dw2-ifort-parameter failure on ARM References: <51E4B587.70007@codesourcery.com> <5280A528.8040308@codesourcery.com> <52D7A05F.6070304@linaro.org> <52D7AAF1.80501@redhat.com> <52D7B3C5.1000702@linaro.org> <52D7D222.9020403@redhat.com> <52D7E4C5.4040504@linaro.org> <52D7E605.4020601@redhat.com> In-Reply-To: <52D7E605.4020601@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00607.txt.bz2 On Thu 16 Jan 2014 07:00:37 PM PKT, Pedro Alves wrote: > On 01/16/2014 01:55 PM, Omair Javaid wrote: >>>> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c b/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c >>>> index 361c44d..c866b0f 100644 >>>> --- a/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c >>>> +++ b/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c >>>> @@ -29,3 +29,9 @@ main (void) >>>> func (); >>>> return 0; >>>> } >>>> + >>>> +/* Addresses represented as data symbols, thus without Thumb (etc.) >>>> + mode bits. The dw2-ifort-parameter-debug.S file uses this as >>>> + func's low_pc/high_pc. */ >>>> +extern void *func_addr __attribute__ ((alias ("func"))); >>>> +extern void *main_addr __attribute__ ((alias ("main"))); >> Patch doesnt fix the issue and builds after making changes to alias definition like: > > Odd. Are you saying the patch didn't build for you? It did for > me, in Thumb mode, and the debug info I saw looked right (no > thumb bit). > >> extern void func_addr() __attribute__ ((alias ("func"))); >> extern void main_addr() __attribute__ ((alias ("main"))); > > ... >> but issues remains the same. > > That's expected, as the whole point was making a data symbol > (void *), but that change makes it a function again (thus > ends up with the thumb bit set again). > I am using gcc version 4.8.1 (Ubuntu/Linaro 4.8.1-10ubuntu9) Patch fails to build with following error: gdb compile failed, ./gdb.dwarf2/dw2-ifort-parameter.c:37:15: error: 'func_addr' alias in between function and variable is not supported extern void * func_addr __attribute__ ((alias ("func"))); ^ ./gdb.dwarf2/dw2-ifort-parameter.c:23:1: warning: 'func' aliased declaration [enabled by default] func (void) ^ ./gdb.dwarf2/dw2-ifort-parameter.c:38:15: error: 'main_addr' alias in between function and variable is not supported extern void * main_addr __attribute__ ((alias ("main"))); ^ ./gdb.dwarf2/dw2-ifort-parameter.c:28:1: warning: 'main' aliased declaration [enabled by default] main (void) ^