From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31873 invoked by alias); 15 Jan 2014 15:54:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31863 invoked by uid 89); 15 Jan 2014 15:54:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2014 15:54:10 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0FFs8kB015047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jan 2014 10:54:08 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0FFs6OG005747; Wed, 15 Jan 2014 10:54:06 -0500 Message-ID: <52D6AF1D.8030602@redhat.com> Date: Wed, 15 Jan 2014 15:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v10 00/28] record-btrace: reverse References: <1389686678-9039-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1389686678-9039-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00511.txt.bz2 On 01/14/2014 08:04 AM, Markus Metzger wrote: > This is a smaller update addressing Pedro's feedback. Thank you. > > The "target: add ops parameter to to_prepare_to_store method" patch has > been replaced with Tom's "Add target_ops argument to to_prepare_to_store" > patch. > > In "record-btrace: provide xfer_partial target method" xfer_partial now > returns an error code instead of throwing an error. > > The "frame: add frame_is_tailcall function" patch has been dropped since > it is no longer needed. Btrace frames use NORMAL_FRAME and TAILCALL_FRAME > instead of new BTRACE_ variants. > > An indentation error where the indentation in "record function-call-history" > had been off by two spaces in some cases has been fixed. I read through the series, and apart from the tiny nits in two patches I sent out, I have no further comments. This looks good to go to me. Congratulations! Quite a neat piece of work. Thanks! -- Pedro Alves