From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1487 invoked by alias); 14 Jan 2014 20:31:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1469 invoked by uid 89); 14 Jan 2014 20:31:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 20:31:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EKVkrv006053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 15:31:46 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0EKVjTB027481; Tue, 14 Jan 2014 15:31:45 -0500 Message-ID: <52D59EB0.2090809@redhat.com> Date: Tue, 14 Jan 2014 20:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: go32 fix References: <1389640367-5571-1-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00479.txt.bz2 > Because this touches every target, I built this on many platforms. I > mostly did build tests because most of the patches are obviously > semantically neutral. > > x86-64 Fedora 18 (native). I built every revision (cumulatively of > course). Regression tested native and with the native-gdbserver > target board. > x86-64 Fedora 18, cross build with Mingw tools. I cross built each > revision. > PPC64 Linux (gcc110 in the compile farm). Built each revision both > normally and with the SPU target enabled. > AIX (gcc111 in the compile farm). > NetBSD 5.1 (gcc70 in the compile farm). I had the cross toolchain handy, so I build the branch for go32/djgpp (i586-pc-msdosdjgpp). It caught a buglet: --- gdb/go32-nat.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c index c42f48a..161e4e7 100644 --- a/gdb/go32-nat.c +++ b/gdb/go32-nat.c @@ -262,8 +262,7 @@ static int go32_can_run (struct target_ops *self); static struct target_ops go32_ops; static void go32_terminal_init (struct target_ops *self); static void go32_terminal_inferior (struct target_ops *self); -static void go32_terminal_ours (struct target_ops *self, - struct target_ops *self); +static void go32_terminal_ours (struct target_ops *self); #define r_ofs(x) (offsetof(TSS,x)) @@ -930,7 +929,7 @@ go32_terminal_inferior (struct target_ops *self) } static void -go32_terminal_ours (struct target_ops *self, struct target_ops *self) +go32_terminal_ours (struct target_ops *self) { /* Switch to cooked mode on the gdb terminal and save the inferior terminal mode to be restored when it is resumed. */ -- 1.7.11.7