From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15592 invoked by alias); 14 Jan 2014 20:07:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15582 invoked by uid 89); 14 Jan 2014 20:07:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 20:07:41 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EK7d1Q028012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 15:07:39 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0EK7cSJ018713; Tue, 14 Jan 2014 15:07:38 -0500 Message-ID: <52D5990A.4030902@redhat.com> Date: Tue, 14 Jan 2014 20:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 31/32] change delegation for to_read_description References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-32-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-32-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00474.txt.bz2 On 01/13/2014 07:12 PM, Tom Tromey wrote: > This switches to_read_description to the "new normal" delegation > scheme. This one was a bit trickier than the other changes due to the > way that target_read_description handled delegation. I examined all > the target implementations of to_read_description and changed the ones > returning NULL to instead delegate. > Looks good to me. A suggestion below. > 2014-01-13 Tom Tromey > > * arm-linux-nat.c (arm_linux_read_description): Delegate when > needed Missing period. > /* Describe the architecture-specific features of this target. > - Returns the description found, or NULL if no description > - was available. */ > - const struct target_desc *(*to_read_description) (struct target_ops *ops); > + Returns the description found. If no description is found, > + this should delegate to the "beneath" target. */ "Returns ... found ... If not found ..." reads a little like a paradox to me. I'd suggest leaving the NULL sentences as is, something like: /* Describe the architecture-specific features of this target. If OPS doesn't have a description, this should delegate to the "beneath" target. Returns the description found, or NULL if no description was available. */ > + const struct target_desc *(*to_read_description) (struct target_ops *ops) > + TARGET_DEFAULT_RETURN (0); -- Pedro Alves