From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31845 invoked by alias); 14 Jan 2014 19:15:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31786 invoked by uid 89); 14 Jan 2014 19:15:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 19:15:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EJFokr007657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 14:15:50 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0EJFmVD029538; Tue, 14 Jan 2014 14:15:49 -0500 Message-ID: <52D58CE4.4090105@redhat.com> Date: Tue, 14 Jan 2014 19:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 27/32] convert to_insert_mask_watchpoint References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-28-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-28-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00464.txt.bz2 On 01/13/2014 07:12 PM, Tom Tromey wrote: > + char *(*to_pid_to_str) (struct target_ops *, ptid_t) > + TARGET_DEFAULT_FUNC (dummy_pid_to_str); This use of "dummy" in the default looked odd to me. I'd suggest renaming it to default_pid_to_str (now or at some point), in line with the other default methods. Otherwise looked good to me. -- Pedro Alves