From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27265 invoked by alias); 14 Jan 2014 18:30:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27239 invoked by uid 89); 14 Jan 2014 18:30:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 18:30:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EIUKhb030137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Jan 2014 13:30:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0EIUHp6025653; Tue, 14 Jan 2014 13:30:18 -0500 Message-ID: <52D58239.8010502@redhat.com> Date: Tue, 14 Jan 2014 18:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC 03/32] introduce async_callback_ftype References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-4-git-send-email-tromey@redhat.com> <52D512FB.7010006@redhat.com> <20140114105012.GF4762@adacore.com> <87a9eyy55d.fsf@fleche.redhat.com> <20140114171858.GG4762@adacore.com> In-Reply-To: <20140114171858.GG4762@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00455.txt.bz2 On 01/14/2014 05:18 PM, Joel Brobecker wrote: >> /* The type of the callback to the to_async method. */ >> >> typedef void async_callback_ftype (enum inferior_event_type event_type, >> void *context); >> "context" is used in several places related to this. OTOH the only >> non-NULL function pointer ever passed to to_async is >> 'inferior_event_handler', which names the second argument "client_data". >> I found them equally clear; particularly once I noticed that all >> existing calls pass context==NULL :) > > That looks good to me, thank you! To me too FWIW. I'd suggest just going ahead and pushing this change in. -- Pedro Alves