From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25134 invoked by alias); 14 Jan 2014 12:48:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25124 invoked by uid 89); 14 Jan 2014 12:48:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 12:48:58 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ECmvSm031768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 07:48:57 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0ECmtKP032544; Tue, 14 Jan 2014 07:48:56 -0500 Message-ID: <52D53237.5070106@redhat.com> Date: Tue, 14 Jan 2014 12:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 09/32] Add target_ops argument to to_close References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-10-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-10-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00429.txt.bz2 Looks good to me. On 01/13/2014 07:12 PM, Tom Tromey wrote: > static void > -ravenscar_prepare_to_store (struct regcache *regcache) > +ravenscar_prepare_to_store (struct target_ops *self, > + struct regcache *regcache) > { > struct target_ops *beneath = find_target_beneath (&ravenscar_ops); > > if (!ravenscar_runtime_initialized () > || ptid_equal (inferior_ptid, base_magic_null_ptid) > || ptid_equal (inferior_ptid, ravenscar_running_thread ())) > - beneath->to_prepare_to_store (regcache); > + beneath->to_prepare_to_store (beneath, regcache); > else > { > struct gdbarch *gdbarch = get_regcache_arch (regcache); (At some point we should go through all find_target_beneath users and make then follow self->beneath instead.) -- Pedro Alves