Re: [PATCH v1 1/3] Add AVX512 registers support to GDB.

["Sturm, Michael" <michael.sturm@intel.com>]

Hi Pedro and Eli,

Sorry for the delay in answering to you, we were out for the holidays. 
Thanks a lot for your review, I'll address your suggestions in the next 
revision of the patch.

Hi Mark,

did you have time to review the patches?

Happy New Year to everybody!

Thanks,
Michael


On 20/12/2013 18:29, Pedro Alves wrote:
> Hi there,
>
> I skimmed this (not a real review), and noticed:
>
>> +send_gdb "print have_avx512 ()\r"
>> +gdb_expect {
> Please use gdb_test_multiple instead of send_gdb/gdb_expect.
>
>> +    -re ".. = 1\r\n$gdb_prompt " {
>> +        pass "check whether processor supports AVX512"
>> +    }
>> +    -re ".. = 0\r\n$gdb_prompt " {
> Should be a pass too:
>
>          pass "check whether processor supports AVX512"
>
> As the test did its job.
>
>
>> +    }
>> +    -re ".*$gdb_prompt $" {
>> +        fail "check whether processor supports AVX512"
>> +    }
>> +    timeout {
>> +        fail "check whether processor supports AVX512 (timeout)"
>> +    }
> These last two won't be necessary then.
>
>> +}
>> +
> This:
>
>
>> +        verbose "processor does not support AVX512; skipping AVX512 tests"
>> +        return
> should probably instead be:
>
>    unsupported "processor does not support AVX512; skipping AVX512 tests"
>
> ...
>
>> +}
>> \ No newline at end of file
> Please add one.
>

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052