From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6210 invoked by alias); 15 Dec 2008 13:22:17 -0000 Received: (qmail 6202 invoked by uid 22791); 15 Dec 2008 13:22:16 -0000 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Dec 2008 13:21:39 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D280A290050; Mon, 15 Dec 2008 14:21:36 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXpkdHd-SAof; Mon, 15 Dec 2008 14:21:20 +0100 (CET) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.0.139]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id D61282900A7; Mon, 15 Dec 2008 14:21:20 +0100 (CET) Cc: gdb-patches@sourceware.org Message-Id: <52D34F10-34A0-4611-938F-FF8CCB2F24CC@adacore.com> From: Tristan Gingold To: Ulrich Weigand In-Reply-To: <200812141737.mBEHbukM021475@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: [RFC] solib for darwin Date: Mon, 15 Dec 2008 13:22:00 -0000 References: <200812141737.mBEHbukM021475@d12av02.megacenter.de.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00281.txt.bz2 On Dec 14, 2008, at 6:37 PM, Ulrich Weigand wrote: > The following patch combines the ops->bfd_open callback I need for > the Cell debugger with the OBJF_KEEPBFD, and also extracts the bulk > of the solib_bfd_open functionality into subroutines that might be > re-used by target-specific implementations. > > Can you verify that this would also allow a Darwin implementation? Hi Ulrich, yes this patch also allows a Darwin implementation. I also think that this approach is better than mine as it is more generic and is smaller. I would be very happy if it were integrated. Just a side comment on your patch: > diff -urNp gdb-orig/gdb/objfiles.c gdb-head/gdb/objfiles.c > --- gdb-orig/gdb/objfiles.c 2008-12-06 20:28:59.000000000 +0100 > +++ gdb-head/gdb/objfiles.c 2008-12-14 17:52:16.000000000 +0100 > @@ -424,7 +424,7 @@ free_objfile (struct objfile *objfile) > > /* We always close the bfd. */ > > - if (objfile->obfd != NULL) > + if (objfile->obfd != NULL && !(objfile->flags & OBJF_KEEPBFD)) Humm, the above comment is not true anymore! Thank you, Tristan.