From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19850 invoked by alias); 9 Jan 2014 18:36:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19840 invoked by uid 89); 9 Jan 2014 18:36:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 18:36:20 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09IaFmm012254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jan 2014 13:36:16 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09IaEVH005680; Thu, 9 Jan 2014 13:36:14 -0500 Message-ID: <52CEEC1D.8050907@redhat.com> Date: Thu, 09 Jan 2014 18:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches ml CC: Doug Evans , Hui Zhu Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> <5298AE7C.6020607@redhat.com> <529C80D2.2080608@mentor.com> <529C9B42.20600@redhat.com> <529D62F7.80701@mentor.com> <52A22582.8040509@redhat.com> <52A40015.207@mentor.com> <52A61E86.3020005@redhat.com> <52A9B236.5060004@redhat.com> In-Reply-To: <52A9B236.5060004@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00252.txt.bz2 On 12/12/2013 12:55 PM, Pedro Alves wrote: > 2013-12-12 Pedro Alves > Hui Zhu > > PR gdb/16101 > * breakpoint.c (insert_bp_location): Rename hw_bp_err_string to > bp_err_string. Don't mark the location shlib_disabled if the > error thrown wasn't a generic or memory error. Catch errors > thrown while inserting breakpoints in overlayed code. Output > error message of software breakpoints. > * remote.c (remote_insert_breakpoint): If this breakpoint has > target-side commands but this stub doesn't support Z0 packets, > throw NOT_SUPPORTED_ERROR error. > * exceptions.h (enum errors) : New error. > * target.h (target_insert_breakpoint): Extend comment. > (target_insert_hw_breakpoint): Add comment. I've pushed this one in. -- Pedro Alves