From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8809 invoked by alias); 9 Jan 2014 12:10:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8799 invoked by uid 89); 9 Jan 2014 12:10:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 12:10:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09CAEFv026552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jan 2014 07:10:14 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09CACXh032664; Thu, 9 Jan 2014 07:10:13 -0500 Message-ID: <52CE91A4.1010908@redhat.com> Date: Thu, 09 Jan 2014 12:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Thomas Schwinge CC: gdb-patches@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH] Make STARTUP_WITH_SHELL a runtime toggle -- add new "set/show startup-with-shell" option. References: <1382532024-28890-1-git-send-email-palves@redhat.com> <83ppqwhu98.fsf@gnu.org> <52693A01.2000108@redhat.com> <8738kyi30l.fsf@kepler.schwinge.homeip.net> In-Reply-To: <8738kyi30l.fsf@kepler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00234.txt.bz2 On 01/08/2014 09:20 PM, Thomas Schwinge wrote: > Hi! > > On Thu, 24 Oct 2013 16:17:21 +0100, Pedro Alves wrote: >> Here's what I pushed > > ..., and what made the Hurd port pretty unhappy. ;-) Whoops. ;-) Thanks for fixing. > In the thread around > , > and > , > we had already (very) briefly been discussing gnu-nat's local > pending_execs handling. Ah, these things do have a tendency to byte back. > Is the new approach that I'm posting below (flag instead of counting; > saves us from repeating in gnu_create_inferior the increment in the > startup_with_shell case) OK until we get a clear understanding if and how > we can get rid of it for good? It's fine with me. > commit 57c9fb3afadab5813d7463dc2393d5affe78849e > Author: Thomas Schwinge > Date: Wed Jan 8 21:42:07 2014 +0100 > > Hurd: Adjust to startup-with-shell changes. > > In commit 98882a26513e25b2161b41dfd4bed97b59b2c01a, STARTUP_WITH_SHELL was made > a runtime toggle, startup-with-shell. The Hurd code not adjusted, which had a "... code was not ..." > value hard-coded instead of using START_INFERIOR_TRAPS_EXPECTED. Fix that, and > also simplify gnu-nat's pending_execs handling from counting to just a flag. -- Pedro Alves