From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23703 invoked by alias); 6 Jan 2014 18:46:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23693 invoked by uid 89); 6 Jan 2014 18:46:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 18:46:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06IkVtq001378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Jan 2014 13:46:31 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s06IkU6t028568; Mon, 6 Jan 2014 13:46:30 -0500 Message-ID: <52CAFA05.5090607@redhat.com> Date: Mon, 06 Jan 2014 18:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] remove overlapping allocation macros References: <1389029524-19907-1-git-send-email-tromey@redhat.com> In-Reply-To: <1389029524-19907-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00081.txt.bz2 On 01/06/2014 05:32 PM, Tom Tromey wrote: > Right now, gdb defines some allocation macros in defs.h, specifically > XZALLOC, XMALLOC, and XCALLOC. libiberty also defines similar > allocation macros, and gdb uses both variants. > > I think it's somewhat nicer if gdb uses just a single set of wrapper > macros, and so this patch series replaces all the uses of the gdb > macros with the corresponding macros from libiberty. > > Let me know what you think. > > Tested by rebuilding on x86-64 Fedora 18 I assume an --enable-targets=all build. and doing a cross build to > mingw. It's possible therefore that there are some buglets remaining. Looks fine to me. -- Pedro Alves