From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9575 invoked by alias); 3 Jan 2014 14:38:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9565 invoked by uid 89); 3 Jan 2014 14:38:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jan 2014 14:38:35 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s03EcWVO018716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Jan 2014 09:38:32 -0500 Received: from [10.36.6.22] (vpn1-6-22.ams2.redhat.com [10.36.6.22]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s03EcUKG015333 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 3 Jan 2014 09:38:32 -0500 Message-ID: <52C6CAB2.9020108@redhat.com> Date: Fri, 03 Jan 2014 14:38:00 -0000 From: nick clifton User-Agent: Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0 SeaMonkey/2.22.1 MIME-Version: 1.0 To: Edjunior Barbosa Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix copy of filename in bfd's filename field References: <1388753936-2835-1-git-send-email-emachado@linux.vnet.ibm.com> In-Reply-To: <1388753936-2835-1-git-send-email-emachado@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00007.txt.bz2 Hi Edjunior, > gdb/ > 2014-01-03 Edjunior Barbosa Machado > > * gdb_bfd.c (gdb_bfd_stash_filename): Fix copy of filename in bfd's > filename field using xstrdup. > @@ -69,7 +69,7 @@ gdb_bfd_stash_filename (struct bfd *abfd) > strcpy (data, name); > > /* Unwarranted chumminess with BFD. */ > - abfd->filename = data; > + abfd->filename = xstrdup (data); > } > > /* An object of this type is stored in each BFD's user data. */ It might be nice to remove the comment too. :-) Cheers Nick