From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3869 invoked by alias); 23 Dec 2013 17:48:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3859 invoked by uid 89); 23 Dec 2013 17:48:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Dec 2013 17:47:42 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 23 Dec 2013 17:47:40 +0000 Received: from [10.1.201.52] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 23 Dec 2013 17:47:40 +0000 Message-ID: <52B8773B.206@arm.com> Date: Mon, 23 Dec 2013 17:48:00 -0000 From: Yufeng Zhang User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches , Marcus Shawcroft , Tom Tromey Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: <52B86A61.1010004@arm.com> In-Reply-To: X-MC-Unique: 113122317474000201 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00891.txt.bz2 On 12/23/13 17:18, Sergio Durigan Junior wrote: > On Monday, December 23 2013, Yufeng Zhang wrote: > >> Hi Sergio, > > Hey Yufeng, > >> Thanks for the updated patch. It looks OK to me and the only comment >> I have is about the '$' character. In A64, only '#' can be the >> optional prefix for immediate. I didn't see '$' checked in your >> original patch; is there a particular reason that you added support >> for '$' in this patch? > > Thanks a lot. You are right, only '#' is an optional prefix in > AArch64. Here's an updated patch. Thank you for your prompt action. It looks good to me. Please ask Tom=20 (or other global maintainer) for an approval if you need to get it in today. Thanks, Yufeng