From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 815 invoked by alias); 19 Dec 2013 18:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 793 invoked by uid 89); 19 Dec 2013 18:30:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 18:30:44 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJIUfvP022969 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Dec 2013 13:30:42 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBJIUcPf017987; Thu, 19 Dec 2013 13:30:39 -0500 Message-ID: <52B33B4E.8070409@redhat.com> Date: Thu, 19 Dec 2013 18:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v9 14/29] target: add ops parameter to to_prepare_to_store method References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-15-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1387471499-29444-15-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00794.txt.bz2 On 12/19/2013 04:44 PM, Markus Metzger wrote: > To allow forwarding the prepare_to_store request to the target beneath, > add a target_ops * parameter. > > 2013-12-19 Markus Metzger > > * target.h (target_ops) : Add parameter. > (target_prepare_to_store): Remove macro. New function. > * target.c (update_current_target): Do not inherit/default > prepare_to_store. > (target_prepare_to_store): New. > (debug_to_prepare_to_store): Remove. > * remote.c (remote_prepare_to_store): Add parameter. > * remote-mips.c (mips_prepare_to_store): Add parameter. > * remote-m32r-sdi.c (m32r_prepare_to_store): Add parameter. > * ravenscar-thread.c (ravenscar_prepare_to_store): Add > parameter. > * monitor.c (monitor_prepare_to_store): Add parameter. > * inf-child.c (inf_child_prepare_to_store): Add parameter. There are more sites that need updating. E.g., go32-nat.c, nto-procfs.c, windows-nat.c, possibly others. Try grepping for to_prepare_to_store. > - de_fault (to_prepare_to_store, > - (void (*) (struct regcache *)) > - noprocess); ... > +void > +target_prepare_to_store (struct regcache *regcache) > +{ > + struct target_ops *t; > + > + for (t = current_target.beneath; t != NULL; t = t->beneath) > + { > + if (t->to_prepare_to_store != NULL) > + { > + t->to_prepare_to_store (t, regcache); > + if (targetdebug) > + fprintf_unfiltered (gdb_stdlog, "target_prepare_to_store ()\n"); > + > + return; > + } > + } There should be a noprocess() call after the loop here. > +} -- Pedro Alves