From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24630 invoked by alias); 19 Dec 2013 18:23:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24618 invoked by uid 89); 19 Dec 2013 18:23:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 18:23:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJINavD017538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Dec 2013 13:23:36 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBJINYmu001992; Thu, 19 Dec 2013 13:23:35 -0500 Message-ID: <52B339A6.3050205@redhat.com> Date: Thu, 19 Dec 2013 18:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v9 11/29] record-btrace: optionally indent function call history References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-12-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1387471499-29444-12-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00792.txt.bz2 On 12/19/2013 04:44 PM, Markus Metzger wrote: > Add a new modifier /c to the "record function-call-history" command to > indent the function name based on its depth in the call stack. > > Also reorder the optional fields to have the indentation at the very beginning. > Prefix the insn range (/i modifier) with "inst ". I was a little surprised the manual didn't get an update for this one, but I see an /i example is currently lacking. Can one use both /i and /l at the same time ? > Change the range syntax from "begin-end" to "begin,end" to allow copy&paste to > the "record instruction-history" and "list" commands. (This bit seems to be missing in NEWS. Not sure it was on purpose.) > There is one known bug regarding indentation that results from the fact that we > have the current instruction already inside the branch trace. When the current > instruction is the first (and only) instruction in a function on the outermost > level for which we have not seen the call, the indentation starts at level 1 > with 2 leading spaces. Hmm. Why are we adding known bugs? I'm not sure I understood it, but from your description it sounds like the condition should be detectable? -- Pedro Alves