From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32739 invoked by alias); 18 Dec 2013 16:24:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32730 invoked by uid 89); 18 Dec 2013 16:24:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 16:24:29 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIGOOfl021066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Dec 2013 11:24:24 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBIGOMHn012436; Wed, 18 Dec 2013 11:24:23 -0500 Message-ID: <52B1CC36.2010501@redhat.com> Date: Wed, 18 Dec 2013 16:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yufeng Zhang CC: "gdb-patches@sourceware.org" , Marcus Shawcroft Subject: Re: [PATCH, AArch64] Fix bug in hardware watchpoint/breakpoint handling References: <52B1C84F.4000102@arm.com> In-Reply-To: <52B1C84F.4000102@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00708.txt.bz2 On 12/18/2013 04:07 PM, Yufeng Zhang wrote: > This patch fixes an AArch64 GDB bug in handling the hardware debug > registers. GDB calls ptrace to set hardware debug registers and it > passes a full-length "struct user_hwdebug_state" variable regardless of > the number of hardware debug registers available on a target. When > there are fewer than 16 (the maximum number) hardware > breakpoint/watchpoint registers on a target, the kernel will complain > about the gdb's request to set non-existing hardware debug registers. > There will be an warning of "Unexpected error setting hardware debug > registers" when the inferior starts to run. > > This patch fixes the issue by setting iov.iov_len with a value > reflecting the exact size in use. > > OK for the mainline? OK. Thanks, -- Pedro Alves