From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108490-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 483 invoked by alias); 18 Dec 2013 11:17:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 473 invoked by uid 89); 18 Dec 2013 11:17:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 11:17:10 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIBH5KL007718	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 18 Dec 2013 06:17:07 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBIBH4a3025745;	Wed, 18 Dec 2013 06:17:04 -0500
Message-ID: <52B1842F.5020401@redhat.com>
Date: Wed, 18 Dec 2013 11:17:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Doug Evans <dje@google.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability
References: <yjt2zjnztait.fsf@ruffy.mtv.corp.google.com>
In-Reply-To: <yjt2zjnztait.fsf@ruffy.mtv.corp.google.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-12/txt/msg00694.txt.bz2

On 12/17/2013 09:47 PM, Doug Evans wrote:
> +   We could also use indentation, but that's adds more complexity.

"but that adds"

Looks good to me, though I think it'd be better to write it as:

linux_wait_1 ()
...
/* Debugging output is delimited to make it easier to read.  */
#define DELIMITER "====\n"
  if (debug_threads)
    fprintf (stderr, DELIMITER "linux_wait_1: [%s]\n", target_pid_to_str (ptid));
  ...
  ...
  if (debug_threads)
    fprintf (stderr, "linux_wait_1 ret = null_ptid\n" DELIMITER);

#undef DELIMITER
}

-- 
Pedro Alves