RE: [patch v8 15/24] frame, backtrace: allow targets to supply a frame unwinder

Metzger, Markus T
2013-12-17T08:26:48Z

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Monday, December 16, 2013 8:02 PM

> >> ... parts look a bit unrelated. It'd be good to have
> >> the rationale for this spelled out. I can understand
> >> why they might be necessary, but I don't see why
> >> target vs non-unwinders unwinders would be special here?
> >
> > Those changes are not directly related to target vs non-target
> > unwinders. They are connected in that they allow new types
> > of unwinders.
>
> >
> > I spelled out the rationale for each change in the commit
> > message.
>
> If I missed it, please point me at it. E.g., I didn't see a
> rationale for the get_frame_unwind_stop_reason change.
> Something like "We need to do X in get_frame_unwind_stop_reason
> because otherwise, when we do Y, W doesn't work."

I meant that based on your review, I now spell out the rationale
for each change in the commit message. I have not sent the updated
patch, yet.

> > Should I further split this patch into three?
>
> IMO, yes.

OK. I'll do that, as well.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052