From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14046 invoked by alias); 16 Dec 2013 18:05:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14036 invoked by uid 89); 16 Dec 2013 18:05:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 18:05:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBGI5QwP005306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Dec 2013 13:05:26 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBGI5Oi7017393; Mon, 16 Dec 2013 13:05:25 -0500 Message-ID: <52AF40E4.1020709@redhat.com> Date: Mon, 16 Dec 2013 18:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Pierre Muller , gdb-patches@sourceware.org Subject: Re: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing References: <002f01cef853$f44500e0$dccf02a0$@muller@ics-cnrs.unistra.fr> <52AE633E.9020604@codesourcery.com> In-Reply-To: <52AE633E.9020604@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00594.txt.bz2 On 12/16/2013 02:19 AM, Yao Qi wrote: > GetModuleFileNameEx is also used in get_module_name, so probably we can > copy its pattern here too > > #ifdef __CYGWIN__ > len = GetModuleFileNameEx (current_process_handle, DllHandle, > pathbuf, __PMAX); > if (cygwin_conv_path (CCP_WIN_W_TO_POSIX, pathbuf, dll_name_ret, > __PMAX) < 0) > ... > #else > len = GetModuleFileNameEx (current_process_handle, > DllHandle, dll_name_ret, __PMAX); > #endif > > and code is more consistent on using GetModuleFileNameEx. At this level we're thinking in terms of Win32 debug API, and it's irrelevant what Cygwin thinks is the Posix path of ntdll.dll. If this is indeed ntdll.dll, then the following windows_make_so call will then do that conversion before recording the dll name. -- Pedro Alves