From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26336 invoked by alias); 16 Dec 2013 17:50:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26326 invoked by uid 89); 16 Dec 2013 17:50:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 17:50:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBGHoJHN022094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Dec 2013 12:50:19 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBGHoHRJ002144; Mon, 16 Dec 2013 12:50:18 -0500 Message-ID: <52AF3D59.6030301@redhat.com> Date: Mon, 16 Dec 2013 17:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches Subject: Re: [PATCH] Improve and fix catch-syscall.exp References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00587.txt.bz2 On 12/13/2013 11:05 PM, Sergio Durigan Junior wrote:> diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp > index 7f1bd29..172890c 100644 > --- a/gdb/testsuite/gdb.base/catch-syscall.exp > +++ b/gdb/testsuite/gdb.base/catch-syscall.exp > @@ -24,7 +24,7 @@ if { [is_remote target] || ![isnative] } then { > } > > # Until "catch syscall" is implemented on other targets... > -if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then { > +if { ![istarget "*-linux*"] } { > continue > } Why's that? AFAICS, hpux does support catching syscalls, at least by number I assume should work. See TARGET_WAITKIND_SYSCALL_ENTRY, etc. being handled in inf-ttrace.c. It might be better to leave the testing exposed there, even if it might be failing miserably. Otherwise, looks like good forward progress to me, irrespective of where the discussion about syscall numbers leads (seems like even if we got the numbers from the program, we'd just tweak fill_all_syscalls_numbers), so other than the above, it looks OK to me. -- Pedro Alves